luoyuxia commented on code in PR #2699: URL: https://github.com/apache/fluss/pull/2699#discussion_r3524194302
########## website/docs/streaming-lakehouse/datalake-formats/iceberg.md: ########## Review Comment: Could we fix this option name while reorganizing the docs? `table.datalake.auto-maintenance` does not exist in `ConfigOptions`; the available table-level options are `table.datalake.auto-compaction` and `table.datalake.auto-expire-snapshot`. Users copying this example would think maintenance is enabled while the option is not a valid Fluss option. For this example, I think we should either remove the line or change it to `table.datalake.auto-compaction` if compaction is intended. ########## website/docs/streaming-lakehouse/union-read.md: ########## @@ -0,0 +1,113 @@ +--- +title: "Union Read" +sidebar_position: 3 +--- + +# Union Read + +Union Read is a core feature of Fluss's Streaming Lakehouse that combines real-time data from Fluss with historical data from the data lake in a single query. + +## Overview + +For a table with `'table.datalake.enabled' = 'true'`, data exists in two layers: +- **Fluss (hot data)**: Sub-second fresh data stored in Arrow format +- **Data Lake (cold data)**: Historical data stored in Parquet format Review Comment: Could we avoid saying the cold layer is always stored in Parquet format? This page covers Paimon/Iceberg/Lance union read in general: Paimon can be configured with ORC, and Lance is not simply Parquet. A more accurate wording would be something like "Historical data stored in the configured lake format/storage". ########## website/docs/streaming-lakehouse/datalake-formats/paimon.md: ########## Review Comment: This page still has a broken relative link to Fluss data types: `table-design/data-types.md` resolves under `streaming-lakehouse/datalake-formats/`. The target is `website/docs/table-design/data-types.md`, so this should be `../../table-design/data-types.md`. ########## website/docs/streaming-lakehouse/datalake-formats/lance.md: ########## Review Comment: Same broken relative link here: `table-design/data-types.md` resolves under `streaming-lakehouse/datalake-formats/`, while the actual target is `website/docs/table-design/data-types.md`. Please change it to `../../table-design/data-types.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
