[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114756#comment-16114756
]
ASF GitHub Bot commented on GEODE-3261:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/685
GEODE-3261: Refactoring GfshHelpCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3261)
`GfshHelpCommands` has been split into two new command classes,
`GfshHelpCommand` and `GfshHintCommand`. One associated test,
`HelperIntegrationTest`, has been updated to reflect this change.
**TESTING STATUS: Precheckin in progress**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Commit single and squashed
- [x] `gradlew build` runs cleanly
- [ ] Tests updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #685
----
commit c02976dd103967f9eda3dfb59669bc1096d7dbb8
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-08-04T18:12:50Z
GEODE-3261: Refactoring GfshHelpCommands
----
> Refactor GfshHelpCommands
> -------------------------
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
