[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114930#comment-16114930
]
ASF GitHub Bot commented on GEODE-3261:
---------------------------------------
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131479491
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
@@ -34,7 +36,7 @@
public static void beforeClass() {
helper = new Helper();
// use GfshHelpCommand for testing
- Method[] methods = GfshHelpCommands.class.getMethods();
+ Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --
With the original multiple-command class being split, this test now only
checks one of the two commands. Add a second test for GfshHintCommand. I would
add it to this test class, refactoring the beforeClass functionality into
separate imnplementations in each test.
> Refactor GfshHelpCommands
> -------------------------
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
