[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116842#comment-16116842
]
ASF GitHub Bot commented on GEODE-3261:
---------------------------------------
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/685#discussion_r131705221
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java
---
@@ -34,7 +36,7 @@
public static void beforeClass() {
helper = new Helper();
// use GfshHelpCommand for testing
- Method[] methods = GfshHelpCommands.class.getMethods();
+ Method[] methods = GfshHelpCommand.class.getMethods();
--- End diff --
Good idea - thank you for your feedback! I don't think the original test
ever actually tested the hint command, so I wrote two completely new tests:
`HelperIntegrationTest.TestHintWithInput` and
`HelperIntegrationTest.TestHintWithoutInput`. PR has also been updated!
> Refactor GfshHelpCommands
> -------------------------
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
