[
https://issues.apache.org/jira/browse/GEODE-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217346#comment-16217346
]
ASF GitHub Bot commented on GEODE-3705:
---------------------------------------
WireBaron commented on a change in pull request #967: GEODE-3705: Refactor
Authentication request to be processed as a "normal" protobuf message
URL: https://github.com/apache/geode/pull/967#discussion_r146636660
##########
File path:
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/security/NoOpAuthenticator.java
##########
@@ -12,23 +12,23 @@
* or implied. See the License for the specific language governing permissions
and limitations under
* the License.
*/
-package org.apache.geode.internal.protocol.protobuf.security;
+package org.apache.geode.internal.protocol.security;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import org.apache.geode.internal.security.SecurityService;
+import org.apache.geode.security.AuthenticationFailedException;
/**
* An implementation of {@link Authenticator} that doesn't use its parameters
and always returns
* true.
*/
-public class NoOpAuthenticator implements Authenticator {
+public class NoOpAuthenticator implements Authenticator<Object, Object> {
+
@Override
- public Object authenticate(InputStream inputStream, OutputStream
outputStream,
- SecurityService securityService) throws IOException {
- // this method needs to do nothing as it is a pass-through implementation
+ public Object authenticate(Object inputObject) throws
AuthenticationFailedException {
return new Object();
Review comment:
Should we just return the same dummy object for each call rather than
creating a new object each time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Authentication request to be processed as a "normal" protobuf message
> ------------------------------------------------------------------------------
>
> Key: GEODE-3705
> URL: https://issues.apache.org/jira/browse/GEODE-3705
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Galen O'Sullivan
> Assignee: Udo Kohlmeyer
>
> Refactor authentication and Authorization for the new protocol to process the
> AuthenticationRequest as a "normal" protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
