[
https://issues.apache.org/jira/browse/GEODE-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217348#comment-16217348
]
ASF GitHub Bot commented on GEODE-3705:
---------------------------------------
WireBaron commented on a change in pull request #967: GEODE-3705: Refactor
Authentication request to be processed as a "normal" protobuf message
URL: https://github.com/apache/geode/pull/967#discussion_r146638591
##########
File path:
geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/ProtobufShiroAuthenticatorJUnitTest.java
##########
@@ -41,7 +42,7 @@
private static final String TEST_USERNAME = "user1";
private static final String TEST_PASSWORD = "hunter2";
private ByteArrayInputStream byteArrayInputStream; // initialized with an
incoming request in
- // setUp.
+ // setUp.
Review comment:
So, does spotless just randomly change how it does formatting? This doesn't
look like something you changed, and presumably it was passing spotlessApply
prior to this...so why did this get changed now? (Not really an issue with
your code, just venting)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Authentication request to be processed as a "normal" protobuf message
> ------------------------------------------------------------------------------
>
> Key: GEODE-3705
> URL: https://issues.apache.org/jira/browse/GEODE-3705
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Galen O'Sullivan
> Assignee: Udo Kohlmeyer
>
> Refactor authentication and Authorization for the new protocol to process the
> AuthenticationRequest as a "normal" protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
