[ 
https://issues.apache.org/jira/browse/GEODE-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217345#comment-16217345
 ] 

ASF GitHub Bot commented on GEODE-3705:
---------------------------------------

WireBaron commented on a change in pull request #967: GEODE-3705: Refactor 
Authentication request to be processed as a "normal" protobuf message
URL: https://github.com/apache/geode/pull/967#discussion_r146637371
 
 

 ##########
 File path: 
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/security/processors/AuthorizationSecurityProcessor.java
 ##########
 @@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.protocol.security.processors;
+
+import org.apache.geode.internal.protocol.MessageExecutionContext;
+import org.apache.geode.internal.protocol.OperationContext;
+import org.apache.geode.internal.protocol.security.SecurityProcessor;
+
+public class AuthorizationSecurityProcessor implements 
SecurityProcessor<Object> {
+  @Override
+  public void validateOperation(Object request, MessageExecutionContext 
messageExecutionContext,
+      OperationContext operationContext) {
+    messageExecutionContext.getAuthorizer().authorize(
 
 Review comment:
   This is going to allow reauthentication (assuming the user is authorized for 
DATA READ operations), is that what we wanted to do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Refactor Authentication request to be processed as a "normal" protobuf message
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-3705
>                 URL: https://issues.apache.org/jira/browse/GEODE-3705
>             Project: Geode
>          Issue Type: New Feature
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Assignee: Udo Kohlmeyer
>
> Refactor authentication and Authorization for the new protocol to process the 
> AuthenticationRequest as a "normal" protobuf message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to