[
https://issues.apache.org/jira/browse/GEODE-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217625#comment-16217625
]
ASF GitHub Bot commented on GEODE-3705:
---------------------------------------
kohlmu-pivotal commented on a change in pull request #967: GEODE-3705: Refactor
Authentication request to be processed as a "normal" protobuf message
URL: https://github.com/apache/geode/pull/967#discussion_r146680819
##########
File path:
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/registry/ProtobufOperationContextRegistry.java
##########
@@ -45,6 +46,13 @@ public OperationContext getOperationContext(RequestAPICase
apiCase) {
}
private void addContexts() {
+ operationContexts.put(RequestAPICase.AUTHENTICATIONREQUEST,
+ new
OperationContext<>(ClientProtocol.Request::getAuthenticationRequest,
+ new AuthenticationRequestOperationHandler(),
+ opsResp ->
ClientProtocol.Response.newBuilder().setAuthenticationResponse(opsResp),
+ new ResourcePermission(ResourcePermission.Resource.DATA,
Review comment:
Not sure what we can do here... but we never authorize authentication
messages. The handler should not allow authentication to happen more than once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Authentication request to be processed as a "normal" protobuf message
> ------------------------------------------------------------------------------
>
> Key: GEODE-3705
> URL: https://issues.apache.org/jira/browse/GEODE-3705
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Galen O'Sullivan
> Assignee: Udo Kohlmeyer
>
> Refactor authentication and Authorization for the new protocol to process the
> AuthenticationRequest as a "normal" protobuf message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
