[
https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227646#comment-16227646
]
ASF GitHub Bot commented on GEODE-3894:
---------------------------------------
WireBaron commented on a change in pull request #985: GEODE-3894: Create
HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r148132854
##########
File path:
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/ProtobufLocatorPipeline.java
##########
@@ -23,28 +23,32 @@
import org.apache.geode.cache.IncompatibleVersionException;
import org.apache.geode.distributed.internal.InternalLocator;
import org.apache.geode.internal.cache.client.protocol.ClientProtocolProcessor;
+import org.apache.geode.internal.protocol.state.ConnectionStateProcessor;
import org.apache.geode.internal.protocol.MessageExecutionContext;
+import
org.apache.geode.internal.protocol.state.NoSecurityConnectionStateProcessor;
import org.apache.geode.internal.protocol.statistics.ProtocolClientStatistics;
@Experimental
public final class ProtobufLocatorPipeline implements ClientProtocolProcessor {
private final ProtocolClientStatistics statistics;
private final InternalLocator locator;
private final ProtobufStreamProcessor streamProcessor;
+ private final ConnectionStateProcessor locatorConnectionState;
ProtobufLocatorPipeline(ProtobufStreamProcessor protobufStreamProcessor,
ProtocolClientStatistics statistics, InternalLocator locator) {
this.streamProcessor = protobufStreamProcessor;
this.statistics = statistics;
this.locator = locator;
this.statistics.clientConnected();
+ this.locatorConnectionState = new NoSecurityConnectionStateProcessor();
Review comment:
Yeah, would be nice if we also properly implemented security on the cache...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create HandshakeRequest
> -----------------------
>
> Key: GEODE-3894
> URL: https://issues.apache.org/jira/browse/GEODE-3894
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way
> other requests are handled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
