[
https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227649#comment-16227649
]
ASF GitHub Bot commented on GEODE-3894:
---------------------------------------
WireBaron commented on a change in pull request #985: GEODE-3894: Create
HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r148133725
##########
File path:
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/registry/ProtobufOperationContextRegistry.java
##########
@@ -109,5 +111,12 @@ private void addContexts() {
opsResp ->
ClientProtocol.Response.newBuilder().setGetAvailableServersResponse(opsResp),
new ResourcePermission(ResourcePermission.Resource.CLUSTER,
ResourcePermission.Operation.READ)));
+
+ operationContexts.put(RequestAPICase.HANDSHAKEREQUEST,
+ new
ProtobufOperationContext<>(ClientProtocol.Request::getHandshakeRequest,
+ new HandshakeRequestOperationHandler(),
+ opsResp ->
ClientProtocol.Response.newBuilder().setHandshakeResponse(opsResp),
+ new ResourcePermission(ResourcePermission.Resource.DATA,
+ ResourcePermission.Operation.READ)));
Review comment:
That sounds like a great plan, but unfortunately there isn't an ALL option
for resource or operation fields in ResourcePermissions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create HandshakeRequest
> -----------------------
>
> Key: GEODE-3894
> URL: https://issues.apache.org/jira/browse/GEODE-3894
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way
> other requests are handled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
