[
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255801#comment-16255801
]
ASF GitHub Bot commented on GEODE-3977:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #154: GEODE-3977:
Modifying the QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151508130
##########
File path: clicache/src/QueryService.hpp
##########
@@ -66,65 +75,66 @@ namespace Apache
/// Get a <c>CqQuery</c> object to enable continuous querying.
/// </summary>
/// @endnativeclient
- //generic<class TKey, class TResult>
- CqQuery<TKey, TResult>^ NewCq( String^ query, CqAttributes<TKey,
TResult>^ cqAttr, bool isDurable );
+ generic<class TKey>
+ CqQuery<TKey, TResult>^ NewCq(String^ query, CqAttributes<TKey,
TResult>^ cqAttr, bool isDurable);
+
/// @nativeclient
/// <summary>
/// Get a <c>CqQuery</c> object to enable continuous querying.
/// </summary>
/// @endnativeclient
- //generic<class TKey, class TResult>
+ generic<class TKey>
CqQuery<TKey, TResult>^ NewCq( String^ name, String^ query,
CqAttributes<TKey, TResult>^ cqAttr, bool isDurable );
/// @nativeclient
/// <summary>
/// Close all <c>CqQuery</c> on this client.
/// </summary>
/// @endnativeclient
- void CloseCqs();
+ void CloseCqs();
/// @nativeclient
/// <summary>
/// Get all <c>CqQuery</c> on this client.
/// </summary>
/// @endnativeclient
- //generic<class TKey, class TResult>
- array<CqQuery<TKey, TResult>^>^ GetCqs();
+ generic<class TKey>
+ array<CqQuery<TKey, TResult>^>^ GetCqs();
Review comment:
Formatting is getting out of whack here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> .NET QueryService templating should match usage
> -----------------------------------------------
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> QueryService uses generics
> generic<class TKey, class TResult>
> //generic<class TResult>
> Query<TResult>^ QueryService<TKey, TResult>::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
