[
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255833#comment-16255833
]
ASF GitHub Bot commented on GEODE-3977:
---------------------------------------
mhansonp commented on a change in pull request #154: GEODE-3977: Modifying the
QueryService template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151514551
##########
File path: clicache/src/QueryService.hpp
##########
@@ -51,7 +60,7 @@ namespace Apache
/// <summary>
/// Provides a query service.
/// </summary>
- generic<class TKey, class TResult>
+ generic<class TResult>
Review comment:
I agree, so I will pull all of the templating out of QueryService.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> .NET QueryService templating should match usage
> -----------------------------------------------
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> QueryService uses generics
> generic<class TKey, class TResult>
> //generic<class TResult>
> Query<TResult>^ QueryService<TKey, TResult>::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
