[
https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256108#comment-16256108
]
ASF GitHub Bot commented on GEODE-3977:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #155: GEODE-3977:
QueryService template args removed
URL: https://github.com/apache/geode-native/pull/155#discussion_r151561520
##########
File path: clicache/integration-test/PutGetTestsN.cs
##########
@@ -318,9 +318,9 @@ public void DoRunQuery()
}
else
{
- QueryService<object, object> qs = null;
- qs =
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService<object,
object>();
- Query<object> qry = qs.NewQuery("SELECT * FROM " + m_region.FullPath);
+ QueryService qs = null;
+ qs =
CacheHelper.DCache.GetPoolManager().Find(m_region.Attributes.PoolName).GetQueryService();
Review comment:
Nit - clean things like this where declared on one line and assigned on the
line below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> .NET QueryService templating should match usage
> -----------------------------------------------
>
> Key: GEODE-3977
> URL: https://issues.apache.org/jira/browse/GEODE-3977
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> QueryService uses generics
> generic<class TKey, class TResult>
> //generic<class TResult>
> Query<TResult>^ QueryService<TKey, TResult>::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
