[
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284367#comment-16284367
]
ASF GitHub Bot commented on GEODE-3799:
---------------------------------------
nreich commented on a change in pull request #1109: GEODE-3799: Move backups
towards a pluggable architecture
URL: https://github.com/apache/geode/pull/1109#discussion_r155895232
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupManager.java
##########
@@ -106,65 +109,86 @@ public void validateRequestingAdmin() {
if (abort) {
return new HashSet<>();
}
- HashSet<PersistentID> persistentIds = new HashSet<>();
+ tempDirectory = Files.createTempDirectory("backup_" +
System.currentTimeMillis());
Review comment:
The temporary directory is required because we now do not backup the Oplog
files to their final destination while holding locks that prevent Oplog
deletion. It also results in the user, config files, and deployed jars being
saved in the backup in the state they are in closest to the backup, instead of
eventually being copied (for example, in a future backup to cloud storage,
where there would be a delay between the backup being "done" and transported to
the storage provider.
This method does not inherently use more space during the backup than we did
before (recently) adding the hard-link support, as we copied the oplog files to
where the backup was conducted. Now, if their backup location is remote from
their local filesystem and the temporary location is on a different filesystem
than the disk stores (preventing hard-links), it will use more space on the
local file system for the duration of the backup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create plugin system for specifying where a backup is stored
> ------------------------------------------------------------
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
> Issue Type: Sub-task
> Components: persistence
> Reporter: Nick Reich
> Assignee: Nick Reich
>
> The current logic merges the moving/copying of files with the determining of
> what to backup. To make it possible to store a backup in cloud storage or
> other locations, we need to separate these concerns, putting the variable,
> location-based logic, into a plugin architecture.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
