[
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284453#comment-16284453
]
ASF GitHub Bot commented on GEODE-3799:
---------------------------------------
dschneider-pivotal commented on a change in pull request #1109: GEODE-3799:
Move backups towards a pluggable architecture
URL: https://github.com/apache/geode/pull/1109#discussion_r155902672
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupManager.java
##########
@@ -106,65 +109,86 @@ public void validateRequestingAdmin() {
if (abort) {
return new HashSet<>();
}
- HashSet<PersistentID> persistentIds = new HashSet<>();
+ tempDirectory = Files.createTempDirectory("backup_" +
System.currentTimeMillis());
Review comment:
This temporary directory change seems like a big change to how backup is
done. If we could make sure that if the oplogs are on multiple file systems
that we would copy them to a temp directory on the same file system then I'd
accept this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create plugin system for specifying where a backup is stored
> ------------------------------------------------------------
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
> Issue Type: Sub-task
> Components: persistence
> Reporter: Nick Reich
> Assignee: Nick Reich
>
> The current logic merges the moving/copying of files with the determining of
> what to backup. To make it possible to store a backup in cloud storage or
> other locations, we need to separate these concerns, putting the variable,
> location-based logic, into a plugin architecture.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
