[
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291381#comment-16291381
]
ASF GitHub Bot commented on GEODE-3799:
---------------------------------------
dschneider-pivotal commented on a change in pull request #1109: GEODE-3799:
Move backups towards a pluggable architecture
URL: https://github.com/apache/geode/pull/1109#discussion_r157034138
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/DiskStoreImplIntegrationTest.java
##########
@@ -73,13 +75,10 @@ public void
cleansUpOrphanedBackupFilesOnDiskStoreCreation() throws Exception {
}
cache.close();
- cache = new CacheFactory(null).create();
+ cache = new CacheFactory().create();
Review comment:
Why is it okay to not set MCAST_PORT to "0" here?
I think it would be better if you just had a private method that will create
the cache and you could call that method in both setup and here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create plugin system for specifying where a backup is stored
> ------------------------------------------------------------
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
> Issue Type: Sub-task
> Components: persistence
> Reporter: Nick Reich
> Assignee: Nick Reich
>
> The current logic merges the moving/copying of files with the determining of
> what to backup. To make it possible to store a backup in cloud storage or
> other locations, we need to separate these concerns, putting the variable,
> location-based logic, into a plugin architecture.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
