ASF subversion and git services commented on GEODE-4377:

Commit 6f251af8830a728eaedfda6f72e949e344710504 in geode's branch 
refs/heads/feature/GEODE-4377 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6f251af ]

GEODE-4377: Don't catch encoding exceptions in OperationHandlers

Addressing review comments.

I've added unit tests to ensure that a Success response is returned to
the client if there are any encoding/decoding errors encountered while
processing entries.

In ProtobufResponseUtilities I've modified the error message to contain
the toString() of the exception, which will include the exception class
name and the exception's message.

> Don't catch encoding exceptions in OperationHandlers
> ----------------------------------------------------
>                 Key: GEODE-4377
>                 URL: https://issues.apache.org/jira/browse/GEODE-4377
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
> In the protobuf protocol, we are currently catching EncodingException due to 
> values that we can't deserialize or result values that we can't serialize.
> Encoding and decoding exceptions should be handled differently, so clients 
> can tell if a value was present but could not be serialized.
> Encoding and decoding errors should be handled consistently across operation 
> handlers.
> Probably we could throw Encoding or Decoding exceptions and handle them at a 
> higher level than the individual op handler.

This message was sent by Atlassian JIRA

Reply via email to