ASF subversion and git services commented on GEODE-4377:

Commit dec2cfe1e650d5adcfd41ecabe9b0c9a3f3dc91f in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=dec2cfe ]

GEODE-4377: Don't catch encoding exceptions in OperationHandlers

This adds DecodingException and moves the handling of EncodingException
and this new exception to ProtobufOpsProcessor.

I've also added tests for getAll and putAll to ensure that their
handlers properly process all entries in the presence of a Key or
Entry decoding error.

This closes #1434

> Don't catch encoding exceptions in OperationHandlers
> ----------------------------------------------------
>                 Key: GEODE-4377
>                 URL: https://issues.apache.org/jira/browse/GEODE-4377
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
> In the protobuf protocol, we are currently catching EncodingException due to 
> values that we can't deserialize or result values that we can't serialize.
> Encoding and decoding exceptions should be handled differently, so clients 
> can tell if a value was present but could not be serialized.
> Encoding and decoding errors should be handled consistently across operation 
> handlers.
> Probably we could throw Encoding or Decoding exceptions and handle them at a 
> higher level than the individual op handler.

This message was sent by Atlassian JIRA

Reply via email to