ASF subversion and git services commented on GEODE-4377:

Commit e44bf9e7bdbd9684c3194fc56468fdcd4b910b80 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e44bf9e ]

GEODE-4377: Don't catch encoding exceptions in OperationHandlers

Galen pointed out that the changes for this ticket changed behavior when
we get an encoding error.  The changes cause the connection to be closed
but we used to leave it open.

This commit reverts to the old behavior.  The connection will remain open
and the client can continue to do goofy things and get error responses.

> Don't catch encoding exceptions in OperationHandlers
> ----------------------------------------------------
>                 Key: GEODE-4377
>                 URL: https://issues.apache.org/jira/browse/GEODE-4377
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.0
>          Time Spent: 2h
>  Remaining Estimate: 0h
> In the protobuf protocol, we are currently catching EncodingException due to 
> values that we can't deserialize or result values that we can't serialize.
> Encoding and decoding exceptions should be handled differently, so clients 
> can tell if a value was present but could not be serialized.
> Encoding and decoding errors should be handled consistently across operation 
> handlers.
> Probably we could throw Encoding or Decoding exceptions and handle them at a 
> higher level than the individual op handler.

This message was sent by Atlassian JIRA

Reply via email to