[
https://issues.apache.org/jira/browse/GEODE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099099#comment-17099099
]
ASF GitHub Bot commented on GEODE-8035:
---------------------------------------
kirklund commented on a change in pull request #5014:
URL: https://github.com/apache/geode/pull/5014#discussion_r419567544
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
##########
@@ -1086,6 +1088,27 @@ public static GemFireCacheImpl getForPdx(String reason) {
clientMetadataService = clientMetadataServiceFactory.apply(this);
}
+ @Override
+ public void lockDiskStore(String diskStoreName) {
+ CountDownLatch countDownLatch =
+ diskStoreLatches.putIfAbsent(diskStoreName, new CountDownLatch(1));
+ if (countDownLatch != null) {
+ try {
+ countDownLatch.await();
Review comment:
`putIfAbsent` returns the old value (if any) or null. Are you trying to
await() on the old Latch or the new one you just put in the ConcurrentMap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Parallel Disk Store Recovery when Cluster Restarts
> --------------------------------------------------
>
> Key: GEODE-8035
> URL: https://issues.apache.org/jira/browse/GEODE-8035
> Project: Geode
> Issue Type: Improvement
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeCommons
>
> Currently, when Geode cluster restarts, the disk store recovery is
> serialized. When all regions share the same disk store, the restart process
> is time consuming. To improve the performance, different regions can use
> different disk stores with different disk controllers. And adding parallel
> disk store recovery. This is expected to significantly reduce the time to
> restart Geode cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
