[
https://issues.apache.org/jira/browse/GEODE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101080#comment-17101080
]
ASF GitHub Bot commented on GEODE-8035:
---------------------------------------
jchen21 commented on pull request #5014:
URL: https://github.com/apache/geode/pull/5014#issuecomment-624817108
> Changes look good to me, but I'd really prefer to see one or more new
tests or an old one modified if possible.
>
> I think it's good to add the new methods to InternalCache in order to
avoid casting to concrete impl (GemFireCacheImpl), but it would be best to
avoid making them default empty methods unless they're part of some sort of
deprecated-replacement if that makes sense. I would just remove `default` from
them and modify all the code (mostly tests) that implements InternalCache to
provide empty implementations of the new methods.
@kirklund I am not sure about the disadvantage of default empty methods in
`InternalCache`. I can remove the `default` keyword from `InternalCache` and
let `CacheCreation` and `InternalCacheForClientAccess` implement the empty
method. No test change needed. I don't see significant difference between these
two options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Parallel Disk Store Recovery when Cluster Restarts
> --------------------------------------------------
>
> Key: GEODE-8035
> URL: https://issues.apache.org/jira/browse/GEODE-8035
> Project: Geode
> Issue Type: Improvement
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeCommons
>
> Currently, when Geode cluster restarts, the disk store recovery is
> serialized. When all regions share the same disk store, the restart process
> is time consuming. To improve the performance, different regions can use
> different disk stores with different disk controllers. And adding parallel
> disk store recovery. This is expected to significantly reduce the time to
> restart Geode cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
