[ https://issues.apache.org/jira/browse/GEODE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101069#comment-17101069 ]
ASF GitHub Bot commented on GEODE-8035: --------------------------------------- jchen21 commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r420998299 ########## File path: geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java ########## @@ -620,6 +625,40 @@ public void getCacheServers_isCanonical() { .isSameAs(gemFireCacheImpl.getCacheServers()); } + @Test + public void testLockDiskStore() throws InterruptedException { + int nThread = 10; + String diskStoreName = "MyDiskStore"; + AtomicInteger nTrue = new AtomicInteger(); + AtomicInteger nFalse = new AtomicInteger(); + ExecutorService executorService = Executors.newFixedThreadPool(nThread); Review comment: I had thought about using `ExecutorServiceRule`. However, the return value of `doLockDiskStore()` is non-deterministic. I can't assert the return value of individual thread. I can only count and assert the number of returning values when all threads are done. I am not sure how `ExecutorServiceRule` will serve this test case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Parallel Disk Store Recovery when Cluster Restarts > -------------------------------------------------- > > Key: GEODE-8035 > URL: https://issues.apache.org/jira/browse/GEODE-8035 > Project: Geode > Issue Type: Improvement > Reporter: Jianxia Chen > Assignee: Jianxia Chen > Priority: Major > Labels: GeodeCommons > > Currently, when Geode cluster restarts, the disk store recovery is > serialized. When all regions share the same disk store, the restart process > is time consuming. To improve the performance, different regions can use > different disk stores with different disk controllers. And adding parallel > disk store recovery. This is expected to significantly reduce the time to > restart Geode cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)