[
https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299174#comment-17299174
]
ASF GitHub Bot commented on GEODE-8679:
---------------------------------------
pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r591922542
##########
File path: cppcache/test/LoggingTest.cpp
##########
@@ -103,7 +103,7 @@ class LoggingTest : public testing::Test {
const char* filename, int32_t rollIndex) {
auto baseName = boost::filesystem::path(filename).stem().string();
auto rolledPath =
- logdir / boost::filesystem::path(baseName + "-" +
+ logdir / boost::filesystem::path(baseName + "." +
Review comment:
Integration tests should only be using the public API and dynamically
linking to geode-native. The logger is not a public API. I'm unsure how I
would go about testing file size and disk space limits using an in-memory sink
- did you have something in mind?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace Native logger with 3rd party solution
> ---------------------------------------------
>
> Key: GEODE-8679
> URL: https://issues.apache.org/jira/browse/GEODE-8679
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a native client developer, I would prefer to only maintain code that
> actually implements core features of a Geode client. A logging subsystem is
> definitely not core Geode functionality. Additionally, the existing
> geode-native logger does not properly support the `loig-file-size-limit` and
> `log-disk-space-limit` properties. Rather than attempt to fix the existing
> logging code to properly implement these, we should switch to a 3rd-party
> solution (spdlog or similar) that already has these features available and
> working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
