[
https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343968#comment-17343968
]
ASF GitHub Bot commented on GEODE-8679:
---------------------------------------
pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r631918182
##########
File path: cppcache/test/LoggingTest.cpp
##########
@@ -315,18 +315,14 @@ TEST_F(LoggingTest, logInit) {
apache::geode::client::Log::close();
boost::filesystem::remove("LoggingTest (#).log");
- // Init with invalid filename
+#ifdef WIN32
Review comment:
Moved file/disk space init and filename init tests to their own test
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace Native logger with 3rd party solution
> ---------------------------------------------
>
> Key: GEODE-8679
> URL: https://issues.apache.org/jira/browse/GEODE-8679
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a native client developer, I would prefer to only maintain code that
> actually implements core features of a Geode client. A logging subsystem is
> definitely not core Geode functionality. Additionally, the existing
> geode-native logger does not properly support the `loig-file-size-limit` and
> `log-disk-space-limit` properties. Rather than attempt to fix the existing
> logging code to properly implement these, we should switch to a 3rd-party
> solution (spdlog or similar) that already has these features available and
> working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
