[
https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340400#comment-17340400
]
ASF GitHub Bot commented on GEODE-8679:
---------------------------------------
lgtm-com[bot] commented on pull request #761:
URL: https://github.com/apache/geode-native/pull/761#issuecomment-833813187
This pull request **introduces 1 alert** when merging
0b8e5fb4a715aa7f0fb6c22e860ee65ef19dcf41 into
36c84e2ce8b9f72b5c520e233bd991f1ac8d8894 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-4dbbfe2b6984963c1b3aa280b82a6d465383e19a)
**new alerts:**
* 1 for Constant return type on member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace Native logger with 3rd party solution
> ---------------------------------------------
>
> Key: GEODE-8679
> URL: https://issues.apache.org/jira/browse/GEODE-8679
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a native client developer, I would prefer to only maintain code that
> actually implements core features of a Geode client. A logging subsystem is
> definitely not core Geode functionality. Additionally, the existing
> geode-native logger does not properly support the `loig-file-size-limit` and
> `log-disk-space-limit` properties. Rather than attempt to fix the existing
> logging code to properly implement these, we should switch to a 3rd-party
> solution (spdlog or similar) that already has these features available and
> working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
