[
https://issues.apache.org/jira/browse/HAWQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002777#comment-15002777
]
ASF GitHub Bot commented on HAWQ-44:
------------------------------------
Github user entong commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/92#discussion_r44705494
--- Diff: src/backend/access/external/hd_work_mgr.c ---
@@ -216,51 +216,50 @@ static void assign_pxf_port_to_fragments(int
remote_rest_port, List *fragments)
}
/*
- * Fetches statistics of the PXF datasource from the PXF service
+ * Fetches fragments statistics of the PXF datasource from the PXF service
*
- * The function will generate a delegation token when secure filesystem
mode
+ * The function will generate a delegation token when secure filesystem
mode
* is on and cancel it right after.
*/
-PxfStatsElem *get_pxf_statistics(char *uri, Relation rel, StringInfo
err_msg)
+PxfFragmentStatsElem *get_pxf_fragments_statistics(char *uri, Relation
rel, StringInfo err_msg)
--- End diff --
Many functions in this CL have err_msg as an argument, which is not very
clean API. Is there a better way? Can we emit the error message at the place
the error occurs?
> Advanced statistics for PXF tables
> ----------------------------------
>
> Key: HAWQ-44
> URL: https://issues.apache.org/jira/browse/HAWQ-44
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Labels: Performance
>
> PXF will get full statistics on a table using sampling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
