[
https://issues.apache.org/jira/browse/HAWQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002786#comment-15002786
]
ASF GitHub Bot commented on HAWQ-44:
------------------------------------
Github user entong commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/92#discussion_r44706061
--- Diff: src/backend/commands/analyze.c ---
@@ -933,13 +914,12 @@ static void analyzeRelation(Relation relation, List
*lAttributeNames, bool rooto
else
{
initStringInfo(&err_msg);
-
gp_statistics_estimate_reltuples_relpages_external_pxf(relation, &location,
&estimatedRelTuples, &estimatedRelPages, &err_msg);
+ analyzePxfEstimateReltuplesRelpages(relation, &location,
&estimatedRelTuples, &estimatedRelPages, &err_msg);
if (err_msg.len > 0)
{
- ereport(WARNING,
- (errmsg("skipping \"%s\" --- error
returned: %s",
-
RelationGetRelationName(relation),
- err_msg.data)));
+ elog(ERROR,
+ "%s",
+ err_msg.data);
--- End diff --
If an error occurs, do we abort the entire analyze?
> Advanced statistics for PXF tables
> ----------------------------------
>
> Key: HAWQ-44
> URL: https://issues.apache.org/jira/browse/HAWQ-44
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Labels: Performance
>
> PXF will get full statistics on a table using sampling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
