[ 
https://issues.apache.org/jira/browse/HAWQ-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126608#comment-15126608
 ] 

ASF GitHub Bot commented on HAWQ-178:
-------------------------------------

Github user adamjshook commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/302#issuecomment-178085903
  
    Good to hear from you as well Christian :)
    
    I think you're right on the `identifier `as the means to have an end-tag 
and new-tag.  It's slowly coming back.  The `StreamReader `seeks until it finds 
the identifier, then flushes the `StringBuilder` and appends characters until 
the final end brace is met, accounting for any nested begin brace/end brace 
combinations.  The big problem that happens is if the identifier is embedded as 
a string inside a JSON record, it would create an incomplete record.  If your 
identifier was `record` in the below example where the split is the horizontal 
line, bad stuff would happen.  This is why the expectation was one file = one 
split.
    
    ```
    record : {
    --------------------------
        text : "this is a record"
    }
    ```


> Add JSON plugin support in code base
> ------------------------------------
>
>                 Key: HAWQ-178
>                 URL: https://issues.apache.org/jira/browse/HAWQ-178
>             Project: Apache HAWQ
>          Issue Type: New Feature
>          Components: PXF
>            Reporter: Goden Yao
>            Assignee: Goden Yao
>             Fix For: backlog
>
>         Attachments: PXFJSONPluginforHAWQ2.0andPXF3.0.0.pdf
>
>
> JSON has been a popular format used in HDFS as well as in the community, 
> there has been a few JSON PXF plugins developed by the community and we'd 
> like to see it being incorporated into the code base as an optional package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to