Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1235#discussion_r115551737
--- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
@@ -237,9 +305,13 @@ main() {
if [[ $# -lt 1 ]]; then
usage
fi
+ if [[ -z "$GPHOME" ]]; then
+ GPHOME="/usr/local/hawq"
+ fi
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd -P)"
parse_params "$@"
validate_params
+ sync_rps_configuration
--- End diff --
if sync fails, Ranger definitions are not created, which is not good.
Service can work without standby and without sync, so either not fail (just
warn) or move it to the very last step. Better yet, not to sync at all here, as
I commented above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
