Github user interma commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1235#discussion_r115644616
  
    --- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
    @@ -104,8 +157,18 @@ function get_hawq_password() {
       done
     }
     
    +function sync_rps_configuration() {
    +  if [[ -d $GPHOME/ranger/etc/ && ! -z $HAWQ_STANDBY_HOST ]]; then
    +    cmd="scp $GPHOME/ranger/etc/* $HAWQ_STANDBY_HOST:$GPHOME/ranger/etc/"
    --- End diff --
    
    Reasonable.
    But there are some other stuffs(rps ha tests,docs) assumed the script 
should copy rps configuration files to standby...
    I think copy is also ok, and we can finish other stuffs quickly.
    
    In future, we will go back to consider whether remove copy is more 
easy-to-use for user.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to