Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1235#discussion_r115550883
  
    --- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
    @@ -104,8 +157,18 @@ function get_hawq_password() {
       done
     }
     
    +function sync_rps_configuration() {
    +  if [[ -d $GPHOME/ranger/etc/ && ! -z $HAWQ_STANDBY_HOST ]]; then
    +    cmd="scp $GPHOME/ranger/etc/* $HAWQ_STANDBY_HOST:$GPHOME/ranger/etc/"
    --- End diff --
    
    are we sure we want to copy the files here as part of this script ? I'd say 
it would be better to have it working on a single node only and do any 
cluster-level operations in "hawq" management scripts. Also, in the future 
config files will be managed by Ambari. I'd say it even could be ok to ask 
users to copy the files to standby manually, especially since when failover 
occurs, they will need to provision a new standby and will have to copy config 
files there manually anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to