Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1306#discussion_r148684991
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -216,17 +174,16 @@ function doInit()
determineHadoopDistro
generatePrivateClasspath || return 1
createInstance || return 1
- configureInstance || return 1
deployWebapp || return 1
createLogsDir || return 1
createRunDir || return 1
}
#
-# patchWebapp patches the webapp config files
-# patch applied only if PXF_HOME is defined
+# configureWebapp patches the webapp with pxf and user overriden configs
+# applied only if PXF_HOME is defined
#
-function patchWebapp()
+function configureWebapp()
--- End diff --
since this function is now called on every start, we should not be
unpacking WAR file and edit web.xml -- only catalina files that use dynamic
properties should be regenerated. Ideally, they should be regenerated from
templates that do not get destroyed, so that customers have a chance to change
the template, if needed.
---
