Github user lavjain commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1306#discussion_r148859336
  
    --- Diff: pxf/pxf-service/src/scripts/pxf-service ---
    @@ -249,6 +206,34 @@ function patchWebapp()
         cat $web_file | \
         sed 
"s:<param-value>.*pxf-log4j.properties<\/param-value>:<param-value>$PXF_HOME\/conf\/pxf-log4j.properties<\/param-value>:"
 > web.xml.tmp
         mv web.xml.tmp $web_file
    +
    +    # set port
    +    
catalinaProperties=$instance_root/$instance_name/conf/catalina.properties
    +    cat $catalinaProperties | \
    +    sed 
"s|^[[:blank:]]*connector.http.port=.*$|connector.http.port=$instance_port|g" \
    +    > ${catalinaProperties}.tmp
    +
    +    rm $catalinaProperties
    +    mv ${catalinaProperties}.tmp $catalinaProperties
    --- End diff --
    
    sed -i would be preferred as Alex suggested.


---

Reply via email to