Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1306#discussion_r148838659
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -216,17 +174,16 @@ function doInit()
determineHadoopDistro
generatePrivateClasspath || return 1
createInstance || return 1
- configureInstance || return 1
deployWebapp || return 1
createLogsDir || return 1
createRunDir || return 1
}
#
-# patchWebapp patches the webapp config files
-# patch applied only if PXF_HOME is defined
+# configureWebapp patches the webapp with pxf and user overriden configs
+# applied only if PXF_HOME is defined
#
-function patchWebapp()
+function configureWebapp()
--- End diff --
The purpose of patching the war is so that an update done to PXF as part of
upgrades wouldn't require the user to run pxf init again. They can simply use
pxf restart.
Can evaluate that change outside of this PR
---
