[
https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877294#action_12877294
]
HBase Review Board commented on HBASE-2400:
-------------------------------------------
Message from: "Ryan Rawson" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review171
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.avpr
<http://review.hbase.org/r/128/#comment832>
if this is generated from the genavro, is it possible to get a maven rule
to generate this? Or is that not ready yet?
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment827>
does it make sense to reuse AColumn here?
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment828>
The Java API gets its speed by essentially taking a Result which is an
array of KeyValue, which are just byte arrays and serializing it all as one
large array. On the client side, the client reads the entire array then builds
the KeyValues that provide a view onto this one array.
I don't know how this performance improvement could be done in this avro
interface, but I thought I'd bring it up for reference.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment829>
it would be nice to collapse AResultEntry and AColumnValue, they seem to be
almost the same thing.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment830>
technically speaking getRowOrBefore() isnt a 'public' method, it is
supposed to be mostly used for META support, and I think we are trending to
'dont use for general purpose'.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment831>
these apis are good, but i'm wondering if you'd be open to a new
experimental scanner API we have been interested in for the base RPC...
essentially right now you need 3 RPC calls even to retrieve a small amount
of data. What would an API look like that lets you open, get rows and have
implicit closes if you hit the end of the scan in your 'number of records'
parameter? We'd still have explicit closes for premature client-driven
scan-terminations, but if your goal is to scan to the end, then why do an
explicit close? Also why not have the 'open' also start to return data? The
returned value would probably have to be a struct..
This is more of an optional exercise, so if you dont feel the need, it's
fine.
- Ryan
> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
> Key: HBASE-2400
> URL: https://issues.apache.org/jira/browse/HBASE-2400
> Project: HBase
> Issue Type: Task
> Components: avro
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift
> connector, but using Avro serialization and associated transport and RPC
> server work. Support AAA (audit, authentication, authorization).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
