[ 
https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876483#action_12876483
 ] 

HBase Review Board commented on HBASE-2400:
-------------------------------------------

Message from: "Jeff Hammerbacher" <[email protected]>


bq.  On 2010-06-06 10:23:33, Andrew Purtell wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 106
bq.  > <http://review.hbase.org/r/128/diff/1/?file=979#file979line106>
bq.  >
bq.  >     Likewise, no support for user attributes here.

https://issues.apache.org/jira/browse/HBASE-2688


bq.  On 2010-06-06 10:23:33, Andrew Purtell wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 92
bq.  > <http://review.hbase.org/r/128/diff/1/?file=979#file979line92>
bq.  >
bq.  >     How do you deal with user attributes? A column can have an arbitrary 
set of them. Coprocessors will use this facility. Not necessary to support 
attribute access via fields of the descriptors if there are RPC methods 
available to read or write them.

https://issues.apache.org/jira/browse/HBASE-2688

I genuinely did not notice that these existed. I'll get a subsequent patch out 
once I clean this one up and it goes into trunk.


bq.  On 2010-06-06 10:23:33, Andrew Purtell wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 255
bq.  > <http://review.hbase.org/r/128/diff/1/?file=979#file979line255>
bq.  >
bq.  >     Missing attribute get and set, if not supporting read/write access 
via descriptor structs.

https://issues.apache.org/jira/browse/HBASE-2688


bq.  On 2010-06-06 10:23:33, Andrew Purtell wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 248
bq.  > <http://review.hbase.org/r/128/diff/1/?file=979#file979line248>
bq.  >
bq.  >     Missing attribute get and set, if not supporting read/write access 
via descriptor structs.

https://issues.apache.org/jira/browse/HBASE-2688


bq.  On 2010-06-06 10:23:33, Andrew Purtell wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 181
bq.  > <http://review.hbase.org/r/128/diff/1/?file=979#file979line181>
bq.  >
bq.  >     No support for filters. For REST, the model classes recursively walk 
the filter structure and build a JSON representation that is then passed as a 
string.
bq.  >     
bq.  >     No support for setBatch()
bq.  >     
bq.  >     Consider support for setCacheBlocks() (regionserver level caching) 
and setCaching() (connector level caching)?

https://issues.apache.org/jira/browse/HBASE-2690 is for the caching and 
https://issues.apache.org/jira/browse/HBASE-2687 is for the filters. Thanks for 
letting me know how you did things in the REST interface; I'll try to mimic 
your approach. I held off on implementing because I wasn't quite sure what the 
API would look like.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review138
-----------------------------------------------------------





> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
>                 Key: HBASE-2400
>                 URL: https://issues.apache.org/jira/browse/HBASE-2400
>             Project: HBase
>          Issue Type: Task
>          Components: avro
>            Reporter: Andrew Purtell
>            Priority: Minor
>         Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift 
> connector, but using Avro serialization and associated transport and RPC 
> server work. Support AAA (audit, authentication, authorization). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to