[
https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877279#action_12877279
]
HBase Review Board commented on HBASE-2400:
-------------------------------------------
Message from: "Ryan Rawson" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review164
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment806>
you can probably just use 'hostname' and 'port'. There was a recent patch
in trunk that is attempting to get rid of IP addresses (they cause issues when
they dont align with DNS names, etc) and generally move us to a DNS name world.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment807>
technically the serverName is the serverAddress + startCode... in the Java
code is isnt fully exposed. Not sure what we want to do here, but this is
probably fine as is.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment808>
couldnt you use a empty string if there are no dead server names? im not
sure if arrays can be 0 length in avro :-)
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment809>
same as deadServerNames.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment810>
presumably in the future we would store the authoritative list in avro and
Java would use that enum. Has anyone done this pattern yet?
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment811>
the compression can never be null, because the "NONE" is the catch all
here.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment812>
do we need to make these fields nullable? usually they are true/false in
the java code.
Is this some semi-mechanical translation from a java api?
- Ryan
> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
> Key: HBASE-2400
> URL: https://issues.apache.org/jira/browse/HBASE-2400
> Project: HBase
> Issue Type: Task
> Components: avro
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift
> connector, but using Avro serialization and associated transport and RPC
> server work. Support AAA (audit, authentication, authorization).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
