[ 
https://issues.apache.org/jira/browse/HBASE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003821#comment-13003821
 ] 

stack commented on HBASE-3440:
------------------------------

Patch looks good V.  Usually we put space around the operators such as '='.  
Any chance of a comment in patch on what inferBoundaries is doing?  I'm not 
sure I get it.  Any chance of a test?  You could make inferBoundaries static.  
Would be easy to write a test for it then?  So, when this patch goes in, we 
should remove load_table.rb at same time?  Or better, turn it into a pointer to 
completeBulkLoad?  Good stuff V.



> Clean out load_table.rb and make sure all roads lead to completebulkload tool
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-3440
>                 URL: https://issues.apache.org/jira/browse/HBASE-3440
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.2
>
>         Attachments: blkload-v3.patch
>
>
> Up on list Vidhya tried using load_table.rb with 0.90 and new master and it 
> don't work any more now we assign differently.  Clean out this script.  Make 
> sure all doc points at completebulkload tool instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to