[ 
https://issues.apache.org/jira/browse/HBASE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007192#comment-13007192
 ] 

stack commented on HBASE-3440:
------------------------------

V: Looks good.  Odd thing is your mixing of the test into the src. Usually 
we'll move this out to a class of its own.  I can add that on commit np.  
Regards the question for reviewer, yes, first key would be "", not 'a'.  What 
do you do for first key when splitting?  Does it matter if it uses 'a' or "" 
since its first key?

This code working for you V in your context?

I can change load_table.rb too on commit.

> Clean out load_table.rb and make sure all roads lead to completebulkload tool
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-3440
>                 URL: https://issues.apache.org/jira/browse/HBASE-3440
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.2
>
>         Attachments: blkload-v3.patch, blkload-v4.patch
>
>
> Up on list Vidhya tried using load_table.rb with 0.90 and new master and it 
> don't work any more now we assign differently.  Clean out this script.  Make 
> sure all doc points at completebulkload tool instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to