[ 
https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694379#comment-13694379
 ] 

Ted Yu commented on HBASE-8496:
-------------------------------

On page 6:
bq. In case of per HFile
The sentence seems to be incomplete.

bq. once we close the file we add the Meta data saying tagpresent = true and 
avg_tag_len = 0.
avg_tag_len = 0 would indicate that there is no tag present. Why do we need two 
flags (tagpresent and avg_tag_len) ?
Later compaction is mentioned where tagpresent is changed to false. But we 
should be able to achieve this at the time of flush, right ?

{code}
byte[] tagArray = kv.getTagsArray();
Tag decodeTag = KeyValueUtil.decodeTag(tagArray);
{code}
In the above sample, I would expect decodeTag() to return more than one Tag.
Would all Tags in the KeyValue be returned to filterKeyValue() ? I think it 
would be better if Tag.Type.Visibility is passed to decodeTag() so that only 
visibility Tag is returned.
                
> Implement tags and the internals of how a tag should look like
> --------------------------------------------------------------
>
>                 Key: HBASE-8496
>                 URL: https://issues.apache.org/jira/browse/HBASE-8496
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.98.0
>
>         Attachments: Tag design.pdf
>
>
> The intent of this JIRA comes from HBASE-7897.
> This would help us to decide on the structure and format of how the tags 
> should look like. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to