[
https://issues.apache.org/jira/browse/HBASE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721310#comment-13721310
]
Ted Yu commented on HBASE-8496:
-------------------------------
EncodedScannerV3 has reference to HFileReaderV3.
All it needs is reader.includesTag and reader.getComparator()
reader is accessible to EncodedScannerV2. We only need to store
reader.includesTag, or cast reader to HFileReaderV3 and obtain includesTag at
runtime.
In Mutation.java:
{code}
+ /*
+ * Create a KeyValue with this objects row key and the Put identifier.
+ *
+ * @return a KeyValue with this objects row key and the Put identifier.
+ */
+ KeyValue createPutKeyValue(byte[] family, byte[] qualifier, long ts, byte[]
value, Tag[] tag) {
{code}
Can you add javadoc for tag parameter ? BTW calling the parameter tags would be
better since an array of Tags may be passed.
TagFilter.java needs license. In its filterKeyValue():
{code}
+ if (t.getType() == (byte) 1) {
{code}
Can you introduce a constant so that the meaning of tag type 1 can be easily
understood ?
In transform() method:
{code}
+ } catch (CloneNotSupportedException e) {
+ }
{code}
Add debug log for the above case ?
In CellUtil, I see copyTagTo() and copyTagToForPrefix() but they look the same.
Did I miss something ?
In createCell():
{code}
+ // I need a Cell Factory here. Using KeyValue for now. TODO.
+ // TODO: Make a new Cell implementation that just carries these
+ // byte arrays.
{code}
The above would be done in a follow-on JIRA ?
For tagsIterator():
{code}
+ public void remove() {
+ throw new IllegalStateException();
{code}
Mind add a message to the exception ?
> Implement tags and the internals of how a tag should look like
> --------------------------------------------------------------
>
> Key: HBASE-8496
> URL: https://issues.apache.org/jira/browse/HBASE-8496
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 0.98.0, 0.95.2
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: Comparison.pdf, HBASE-8496.patch, Tag design.pdf
>
>
> The intent of this JIRA comes from HBASE-7897.
> This would help us to decide on the structure and format of how the tags
> should look like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
