[
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751434#comment-13751434
]
Nick Dimiduk commented on HBASE-9116:
-------------------------------------
Overall +1. Everything below are just nits.
---
bq. IMHO this is not going to add that much value. Do you mind if I look at
this in a follow up.
No problem. I don't thing AbstractHBaseTool is used very often within the
codebase anyway.
bq. Fixed the timeout (that was a good catch). The reason the test is clubbed
into one is that the test tries out the various favorednode utilities with a
single table that it creates in the beginning.
I prefer independent tests to run in isolation of each other when at all
possible. Not a show-stopper for the patch -- I regard tweaking test timeouts
as a kind of code smell.
{noformat}
+ <Match>
+ <!--
+ The logic explicitly checks equality of two floating point numbers.
Ignore the warning
+ !-->
+ <Class name="org.apache.hadoop.hbase.master.AssignmentVerificationReport"/>
+ <Bug pattern="FE_FLOATING_POINT_EQUALITY"/>
+ </Match>
{noformat}
AssignmentVerificationReport has separate logic blocks for floating point if (A
> B) else if (A == B) -- I wonder if this will be a future source of bugs.
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
> Key: HBASE-9116
> URL: https://issues.apache.org/jira/browse/HBASE-9116
> Project: HBase
> Issue Type: Improvement
> Components: Region Assignment
> Affects Versions: 0.95.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt,
> 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for
> regions, and also fix the mappings if needed. Such a tool exists in the
> 0.89-fb branch. Will port it over to trunk/0.95.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
