[ 
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751512#comment-13751512
 ] 

Jimmy Xiang commented on HBASE-9116:
------------------------------------

You already defined UpdateFavoredNodesRequest, why not use it? These two calls 
may divert later on.  It is better to use different message so that it will be 
easier to maintain compatibility.

Why does this one take a RegionOpenInfo? At least, it doesn't need the zk node 
version right?
{noformat}
+message UpdateFavoredNodesRequest {
+  repeated OpenRegionRequest.RegionOpenInfo updateRegionInfo = 1;
+}
{noformat}
                
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
>                 Key: HBASE-9116
>                 URL: https://issues.apache.org/jira/browse/HBASE-9116
>             Project: HBase
>          Issue Type: Improvement
>          Components: Region Assignment
>    Affects Versions: 0.95.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 
> 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for 
> regions, and also fix the mappings if needed. Such a tool exists in the 
> 0.89-fb branch. Will port it over to trunk/0.95.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to