[
https://issues.apache.org/jira/browse/HBASE-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805427#comment-13805427
]
Jonathan Hsieh commented on HBASE-9831:
---------------------------------------
Ok. I undertand the problem after looking here
https://github.com/apache/hadoop-common/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ToolRunner.java#L46
and here:
https://github.com/apache/hadoop-common/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configured.java
It looks like we should change HBaseFsck's constructor to not create the
executor or error reporter, and have them be created at the start of the exec
method. That makes it so we always only create the executor once, and always
use all of the -D variables that get added to the conf by the ToolRunner. This
will make it correct for all future -D settings we may add and not just this
single setting. Mind making the change?
> 'hbasefsck.numthreads' property can not pass to hbck via generic option
> -----------------------------------------------------------------------
>
> Key: HBASE-9831
> URL: https://issues.apache.org/jira/browse/HBASE-9831
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.12
> Reporter: takeshi.miao
> Priority: Minor
> Labels: hbck
> Fix For: 0.94.13
>
> Attachments: HBASE-9831-0.94-v02.patch, HBASE-9831-0.94-v03.patch,
> HBASE-9831-trunk-v01.patch, HBASE-9831.v01.patch
>
>
> We use generic option way to pass _'hbasefsck.numthreads'_ property to
> _'hbase hbck'_, but it does not accept our new setting value
> {code}
> hbase hbck -D hbasefsck.numthreads=5
> {code}
> We can still find there are threads over than 5 we already set via generic
> opttion
> {code}
> [2013-10-24
> 09:25:02,561][pool-2-thread-6][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,562][pool-2-thread-10][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,565][pool-2-thread-13][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,566][pool-2-thread-11][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,567][pool-2-thread-9][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,568][pool-2-thread-12][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,570][pool-2-thread-7][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,571][pool-2-thread-14][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
