[
https://issues.apache.org/jira/browse/HBASE-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806520#comment-13806520
]
takeshi.miao commented on HBASE-9831:
-------------------------------------
@Lars & @Jonathan
Tks review and comments, I arrange your comments as following check items
{quote}
1. change HBaseFsck's constructor to not create the executor or error reporter
2. and have them be created at the start of the exec method.
3. That makes it so we always only create the executor once,
4. and always use all of the -D variables that get added to the conf by the
ToolRunner.
5. we need to change the test code that constructs a HBaseFsck object directly
{quote}
I think I still can help to submit a patch for these items in the couple days,
for trunk firstly.
Any comment ?
> 'hbasefsck.numthreads' property can not pass to hbck via generic option
> -----------------------------------------------------------------------
>
> Key: HBASE-9831
> URL: https://issues.apache.org/jira/browse/HBASE-9831
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.94.12
> Reporter: takeshi.miao
> Priority: Minor
> Labels: hbck
> Fix For: 0.98.0, 0.96.1, 0.94.14
>
> Attachments: HBASE-9831-0.94-v02.patch, HBASE-9831-0.94-v03.patch,
> HBASE-9831-trunk-v01.patch, HBASE-9831.v01.patch
>
>
> We use generic option way to pass _'hbasefsck.numthreads'_ property to
> _'hbase hbck'_, but it does not accept our new setting value
> {code}
> hbase hbck -D hbasefsck.numthreads=5
> {code}
> We can still find there are threads over than 5 we already set via generic
> opttion
> {code}
> [2013-10-24
> 09:25:02,561][pool-2-thread-6][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,562][pool-2-thread-10][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,565][pool-2-thread-13][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,566][pool-2-thread-11][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,567][pool-2-thread-9][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,568][pool-2-thread-12][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,570][pool-2-thread-7][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> [2013-10-24
> 09:25:02,571][pool-2-thread-14][DEBUG][org.apache.hadoop.security.UserGroupInformation]:
> PrivilegedAction as:hbase/[email protected]
> (auth:KERBEROS) from:sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) (UserGroupInformation.java:1430)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
