[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858908#comment-13858908
]
stack commented on HBASE-10255:
-------------------------------
My question was 'Out of interest, what brings on the need for an upgrade and
the need to remove LIS? Have you run into an issue that requires this?' It was
not answered before commit. Does this change come of just roaming the code
randomly?
You changed a fundamental class -- one used WAL writing -- w/ one from a
different library altogether with perhaps different motivations. Any
performance regression seen? For sure it works exactly the same way?
> Remove dependency on LimitInputStream
> -------------------------------------
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10255-v1.txt, 10255-v2.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
