[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858918#comment-13858918
]
Ted Yu commented on HBASE-10255:
--------------------------------
bq. Does this change come of just roaming the code randomly?
No. The latest change is to address your comment from HBASE-10174:
bq. I just have a problem with adding classes from said library to hbase core
to make it happen.
bq. the need for an upgrade
There is no upgrade in patch v2.
bq. one used WAL writing
The InputStream class is used in reading. See ProtobufLogReader
bq. For sure it works exactly the same way?
Yes. I compared the source code of
hbase-common/src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java and
http://commons.apache.org/proper/commons-io/apidocs/src-html/org/apache/commons/io/input/BoundedInputStream.html
> Remove dependency on LimitInputStream
> -------------------------------------
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10255-v1.txt, 10255-v2.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
