[
https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860407#comment-13860407
]
Ted Yu commented on HBASE-10255:
--------------------------------
BoundedInputStream is used in the following classes in hadoop:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/ByteRangeInputStream.java
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java
I searched for LimitInputStream in hadoop but didn't find any occurrence.
I did some performance testing. Below was the comparison:
------0.96.1.1
org.apache.hadoop.hbase.regionserver.wal.HLogPerformanceEvaluation:
append:
count = 762367720
mean rate = 2335.76 bytes/ms
1-minute rate = 2362.35 bytes/ms
5-minute rate = 1967.47 bytes/ms
15-minute rate = 1562.28 bytes/ms
syncMeter:
count = 1204781
mean rate = 3.69 syncs/ms
1-minute rate = 3.70 syncs/ms
5-minute rate = 3.08 syncs/ms
15-minute rate = 2.42 syncs/ms
-----with patch:
append:
count = 983061720
mean rate = 2337.51 bytes/ms
1-minute rate = 2360.75 bytes/ms
5-minute rate = 2117.03 bytes/ms
15-minute rate = 1757.53 bytes/ms
syncMeter:
count = 1554486
mean rate = 3.70 syncs/ms
1-minute rate = 3.73 syncs/ms
5-minute rate = 3.34 syncs/ms
15-minute rate = 2.76 syncs/ms
> Remove dependency on LimitInputStream
> -------------------------------------
>
> Key: HBASE-10255
> URL: https://issues.apache.org/jira/browse/HBASE-10255
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed
> to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream,
> long) instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
