[ 
https://issues.apache.org/jira/browse/HBASE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862747#comment-13862747
 ] 

takeshi.miao commented on HBASE-10147:
--------------------------------------

Hi [~gustavoanatoly]
Leaving the legacy one '_Sink.publishReadTiming_' is fine to me, due to I think 
that their purpose is somehow different, 1) '_Sink.publishInfo_' is used to 
prompt user that what portion of the HBase the _monitor_ is going to test, 2) 
'_Sink.publishReadTiming_' is used to tell the user how long the test took.

[~stacke] How do you think ?

A reminder, the abbreviation seems need to be revised.
{code}
...tool.Canary (Canary.java:publishInfo(103)) - Read from Region: ...
...tool.Canary (Canary.java:publishReadTiming(97)) - read from region ...
{code}

> Canary additions
> ----------------
>
>                 Key: HBASE-10147
>                 URL: https://issues.apache.org/jira/browse/HBASE-10147
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Gustavo Anatoly
>         Attachments: HBASE-10147-v2.patch, HBASE-10147-v3.patch, 
> HBASE-10147-v4.patch, HBASE-10147.patch, HBASE-10147.patch, 
> HBASE-10147.patch, HBASE-10147.patch
>
>
> I've been using the canary to quickly identify the dodgy machine in my 
> cluster.  It is useful for this.  What would  make it better would be:
> + Rather than saying how long it took to get a region after you have gotten 
> the region, it'd be sweet to log BEFORE you went to get the region the 
> regionname and the server it is on.  I ask for this because as is, I have to 
> wait for the canary to timeout which can be a while.
> + Second ask is that when I pass the -t, that when it fails, it says what it 
> failed against -- what region and hopefully what server location (might be 
> hard).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to