[
https://issues.apache.org/jira/browse/HBASE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864243#comment-13864243
]
Gustavo Anatoly commented on HBASE-10147:
-----------------------------------------
Hi, [~takeshi.miao]
What do you think, about this changes:
1 - Rename method;
2 - Change output messages;
{code}
@Override
public void publishMonitorInfo(HRegionInfo region, ServerName serverName) {
LOG.info(String.format("Monitoring Region: %s - ServerName: %s",
region.getRegionNameAsString(), serverName.getServerName()));
}
@Override
public void publishMonitorInfoTimeout(HRegionInfo region, ServerName
serverName) {
LOG.info(String.format("Monitor Timeout Region: %s - ServerName: %s",
region.getRegionNameAsString(), serverName.getServerName()));
}
{code}
> Canary additions
> ----------------
>
> Key: HBASE-10147
> URL: https://issues.apache.org/jira/browse/HBASE-10147
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Gustavo Anatoly
> Attachments: HBASE-10147-v2.patch, HBASE-10147-v3.patch,
> HBASE-10147-v4.patch, HBASE-10147.patch, HBASE-10147.patch,
> HBASE-10147.patch, HBASE-10147.patch
>
>
> I've been using the canary to quickly identify the dodgy machine in my
> cluster. It is useful for this. What would make it better would be:
> + Rather than saying how long it took to get a region after you have gotten
> the region, it'd be sweet to log BEFORE you went to get the region the
> regionname and the server it is on. I ask for this because as is, I have to
> wait for the canary to timeout which can be a while.
> + Second ask is that when I pass the -t, that when it fails, it says what it
> failed against -- what region and hopefully what server location (might be
> hard).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
